[Buildroot] [PATCH] fs/common.mk: support comments in user table files

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Peter, Yann,
 > On Fri, 16 Oct 2015 16:50:19 +0200, Peter Korsgaard wrote:
 >> The format of the users table files is non trivial, so it is sometimes handy
 >> to add comments explaining the syntax (or simply the reason for the user)
 >> inline in the files.
 >> 
 >> Support comment lines prefixed with '#' similar to shell / makedevs files and strip
 >> those lines before passing to the mkusers script.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>

 > Shouldn't it the responsibility of the mkusers script to ignore such
 > comments instead ?

It could be, but that is more work as it iterates over the (combined)
file multiple times, and comments only really makes sense for custom
users files (and nog <PKG>_USERS) so just stripping those lines when
handling the custom files imho makes sense.

-- 
Venlig hilsen,
Peter Korsgaard