[Buildroot] [PATCHv2] inadyn: fix init script and default config file

Peter Korsgaard peter at korsgaard.com
Mon Oct 19 07:56:26 UTC 2015


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 > Changes since v1:

 >  * Store PID file in /var/run/inadyn.pid instead of
 >    /var/run/inadyn/inadyn.pid.

 >  * Use the background functionality of start-stop-daemon instead of
 >    the one of inadyn itself (suggested by Gustavo)

Didn't Gustavoz suggest the opposite? E.G. to use the inadyn option to
force the background mode on, independently of what the config file
states?

I also see that you are not passing the --syslog option to inadyn, so
log messages go to stdout (which start-stop-daemon redirects to
/dev/null) :/

> +++ b/package/inadyn/inadyn.conf
 > @@ -1,11 +1,11 @@
 >  # Basic configuration file for inadyn
 >  #
 >  # /etc/inadyn.conf
 > -background
 > +pidfile /var/run/inadyn.pid

We should instead use the --pidfile inadyn command line option to
force this as we _REQUIRE_ this for start-stop-daemon.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list