[Buildroot] [PATCH 04/21 v2] core: commonalise the bundled and br2-external %_defconfig rules

[Arnout Vandecappelle]

On 26-10-15 21:56, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2015-10-26 21:27 +0100, Arnout Vandecappelle spake thusly:
>> On 22-10-15 22:33, Yann E. MORIN wrote:
[snip]
>>> ---
>>>  Makefile | 13 ++++++-------
>>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 60cea32..052f58a 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -789,13 +789,12 @@ defconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
>>>  	@$(COMMON_CONFIG_ENV) $< --defconfig$(if $(DEFCONFIG),=$(DEFCONFIG)) $(CONFIG_CONFIG_IN)
>>>  
>>>  # Override the BR2_DEFCONFIG from COMMON_CONFIG_ENV with the new defconfig
>>
>>  This comment should go inside the define
> 
> Why? The macro only generates Makefile code, so we don;t care that
> comment being replicated for both cases.

 Because the comment should be as close as possible to statement it relates to.
So actually it should be placed after the %_defconfig (which is possible now
since there is only one).

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF