[Buildroot] [2/2, v2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211

Gary Bisson gary.bisson at boundarydevices.com
Thu Sep 17 15:31:27 UTC 2015


Hi Nicolas,

On Fri, Jul 17, 2015 at 09:59:10AM +0200, Nicolas Cavallari wrote:
> Hotspot 2.0 uses ANQP whose implementation needs offchannel/
> remain-on-channel capabilities from the driver, which only exist in the
> nl80211 driver.  Compiling would work, but the feature would not work.
> 
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari at green-communications.fr>
> ---
> 
> v2: added signoff.
>  package/wpa_supplicant/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 29dc4b9..22cf7f8 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -41,6 +41,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP
>  
>  config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT
>  	bool "Enable HS20"
> +	depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211
>  	help
>  	  Enable Hotspot 2.0 and IEEE 802.11u interworking functionality.
>

First I'm not sure on the procedure to test the Hotspot 2.0 but I think
we should at least add a comment like:

comment "HS20 needs NL80211 support"
	depends on !BR2_PACKAGE_WPA_SUPPLICANT_NL80211

Because right now if you unselect NL80211 WPA option the HS20 just
disappears.

Or maybe selecting NL80211 would be even better if absolutely required
at runtime.

Regards,
Gary


More information about the buildroot mailing list