[Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5

Arnout Vandecappelle arnout at mind.be
Wed Sep 2 21:12:31 UTC 2015


On 02-09-15 16:21, Vicente Olivert Riera wrote:
> This version depends on libgudev when using systemd, otherwise it fails
> with an error like this one:
> 
> checking for GUDEV... no
> configure: error: Package requirements (gudev-1.0 >= 147) were not met:
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 However, I think it would be better to take a different approach here, because
there will be more packages with this requirement (we already have libmbim now,
but there are probably more that we haven't detected yet because we don't have
systemd in the autobuilders).

 So I think there should be either a new virtual package or a suboption of udev
to handle the libgudev case.

 But that's more work, so let's fix udisks now by applying this patch.

 Regards,
 Arnout

> ---
> Changes v3 -> v4: improve the libgudev dependency comment [Thomas]
> Changes v2 -> v3: add a comment about the libgudev dependency
> Changes v1 -> v2: depend on libgudev when using systemd
> 
>  package/udisks/Config.in   |    6 ++++++
>  package/udisks/udisks.hash |    2 +-
>  package/udisks/udisks.mk   |   11 ++++++++++-
>  3 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/package/udisks/Config.in b/package/udisks/Config.in
> index a5da2bf..f24df03 100644
> --- a/package/udisks/Config.in
> +++ b/package/udisks/Config.in
> @@ -12,6 +12,12 @@ config BR2_PACKAGE_UDISKS
>  	select BR2_PACKAGE_PARTED
>  	select BR2_PACKAGE_LVM2
>  	select BR2_PACKAGE_LIBATASMART
> +	# When eudev is used as the udev provider, libgudev is automatically
> +	# provided as it is part of eudev. However, when systemd is used as
> +	# the udev provider, libgudev is not provided, and needs to be built
> +	# separately. This is why we select the libgudev package only if
> +	# systemd is used.
> +	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_SYSTEMD
>  	help
>  	  The udisks project provides
>  
> diff --git a/package/udisks/udisks.hash b/package/udisks/udisks.hash
> index 5debfd5..7ad4326 100644
> --- a/package/udisks/udisks.hash
> +++ b/package/udisks/udisks.hash
> @@ -1,2 +1,2 @@
>  # Locally calculated
> -sha256	854b89368733b9c3a577101b761ad5397ae75a05110c8698ac5b29de9a8bf8f5	udisks-1.0.4.tar.gz
> +sha256 f2ec82eb0ea7e01dc299b5b29b3c18cdf861236ec43dcff66b3552b4b31c6f71  udisks-1.0.5.tar.gz
> diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
> index 7a24106..a39ff31 100644
> --- a/package/udisks/udisks.mk
> +++ b/package/udisks/udisks.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -UDISKS_VERSION = 1.0.4
> +UDISKS_VERSION = 1.0.5
>  UDISKS_SITE = http://hal.freedesktop.org/releases
>  UDISKS_LICENSE = GPLv2+
>  UDISKS_LICENSE_FILES = COPYING
> @@ -22,6 +22,15 @@ UDISKS_DEPENDENCIES = 	\
>  
>  UDISKS_CONF_OPTS = --disable-remote-access --disable-man-pages
>  
> +# When eudev is used as the udev provider, libgudev is automatically
> +# provided as it is part of eudev. However, when systemd is used as the
> +# udev provider, libgudev is not provided, and needs to be built
> +# separately. This is why we select the libgudev package only if systemd
> +# is used.
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +UDISKS_CONF_OPTS += libgudev
> +endif
> +
>  ifeq ($(BR2_PACKAGE_UDISKS_LVM2),y)
>  UDISKS_CONF_OPTS += --enable-lvm2
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list