[Buildroot] [PATCH 3/3] Fix uClibc build for ARM-nommu

[Thomas Petazzoni]

Dear Douglas RAILLARD,

On Sat,  5 Sep 2015 18:33:44 +0200, Douglas RAILLARD wrote:

> +# UCLIBC_HAS_CONTEXT_FUNCS is broken with Thumb and Thumb2
> +ifeq (y,$(filter y,$(BR2_ARM_INSTRUCTIONS_THUMB) $(BR2_ARM_INSTRUCTIONS_THUMB2)))

Why such a complicated condition? BR2_ARM_INSTRUCTIONS_THUMB and
BR2_ARM_INSTRUCTIONS_THUMB2 are in a "choice" ... "endchoice" block, so
only one of the two can be set to 'y' at any given time. So you can do:

ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB)$(BR2_ARM_INSTRUCTIONS_THUMB2),y)

instead.

> +define UCLIBC_ARM_THUMB_CONFIG
> +	$(call KCONFIG_ENABLE_OPT,COMPILE_IN_THUMB_MODE,$(@D)/.config)
> +	$(call KCONFIG_DISABLE_OPT,UCLIBC_HAS_CONTEXT_FUNCS,$(@D)/.config)
> +endef
> +endif

Other than that, it looks good to me.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com