[Buildroot] [PATCH v5 1/1] squeezelite: new package

川島 浩 kei-k at ca2.so-net.ne.jp
Mon Sep 21 01:51:25 UTC 2015


Thank you for taking time to review.
Ok, I will post sanity patch again.

Kawashima

> 2015/09/20 20:00、Vincent Olivert Riera <Vincent.Riera at imgtec.com> のメール:
> 
> Dear Hiroshi Kawashima,
> 
> thanks for taking my comments into account and fix all the issue we find during the review process.
> 
> This patch looks good to me, but it has a big issue. You have edited it manually and forgot to change one important thing. Please keep reading.
> 
> On 20/09/15 11:15, kei-k at ca2.so-net.ne.jp wrote:
>> Signed-off-by: Hiroshi Kawashima <kei-k at ca2.so-net.ne.jp>
>> ---
>>  package/Config.in                  |    5 +----
>>  package/squeezelite/Config.in      |   33 +++++++++++++++++++++++++++++++++
> 
> Here you have changed a 32 by a 33, and added one more +. Please keep scrolling down.
> 
>>  package/squeezelite/squeezelite.mk |   30 ++++++++++++++++++++++++++++++
>>  3 files changed, 63 insertions(+), 4 deletions(-)
>>  create mode 100644 package/squeezelite/Config.in
>>  create mode 100644 package/squeezelite/squeezelite.mk
>> 
>> diff --git a/package/Config.in b/package/Config.in
>> index 22aef52..57f4498 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -33,6 +33,7 @@ menu "Audio and video applications"
>>  	source "package/opus-tools/Config.in"
>>  	source "package/pulseaudio/Config.in"
>>  	source "package/sox/Config.in"
>> +	source "package/squeezelite/Config.in"
>>  	source "package/tidsp-binaries/Config.in"
>>  	source "package/tovid/Config.in"
>>  	source "package/tstools/Config.in"
>> diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
>> new file mode 100644
>> index 0000000..c27dac2
>> --- /dev/null
>> +++ b/package/squeezelite/Config.in
>> @@ -0,0 +1,32 @@
> 
> But you forgot to change this 32 here and put 33, so when we apply your patch only 32 lines are written to package/squeezelite/Config.in.
> 
> Please, _NEVER_ edit patches manually. Always regenerate them using "git format-patch".
> 
> In fact, I don't know why are you generating the patch file (since you are not adding a changelog) and then sending it by email. You can just send by email your latest commit with "git send-email --to=buildroot at buildroot.org --subject-prefix="PATCHv6" -1".
> 
> When we find issues during the review, you have to fix the issues by editing the needed files. Then add those files again with "git add <the file>", and then amend your commit with "git commit --amend". That workflow is much easier and faster.
> 
> Regards,
> 
> Vincent.
> 
> [snip]




More information about the buildroot mailing list