[Buildroot] [PATCHv2] micropython: fix build for MIPS64 n32
Chris Packham
judge.packham at gmail.com
Wed Sep 23 23:12:59 UTC 2015
Hi Peter,
On Thu, Sep 24, 2015 at 9:12 AM, Peter Korsgaard <peter at korsgaard.com> wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
>
> > This patch applies an upstream patch to fix a compile error like this
> > one:
>
> > modffi.c: In function 'ffifunc_call':
> > modffi.c:358:25: error: cast from pointer to integer of different size
> > [-Werror=pointer-to-int-cast]
> > values[i] = (ffi_arg)a;
>
> > This error can be highlighted when building micropython for MIPS64 n32
> > because ffi_arg is 64-bit wide and the pointers on MIPS64 n32 are 32-bit
> > wide, so it's trying to case an integer to a pointer (or vice versa) of
> > a different size. We should cast first the pointer (or the integer) to a
> > pointer sized integer (intptr_t) to fix that problem.
>
> > This patch was merged upstream as a result of this pull request:
>
> > https://github.com/micropython/micropython/pull/1471
>
> > Fixes:
>
> > http://autobuild.buildroot.net/results/e22/e2253de3f96e9a53e75b4cecaf56c1df2950803f/
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>
> Committed, thanks.
>
> If we need to apply any more patches then I think it makes more sense to
> get the sources from git (or convince upstream to make a new release).
>
I think they heard you :) 1.4.6 was just released. I'll send a patch
through for that shortly.
More information about the buildroot
mailing list