[Buildroot] [PATCH v2 1/4] Remove trailing slash from all package site URLs

Luca Ceresoli luca at lucaceresoli.net
Sun Sep 27 11:50:51 UTC 2015


Hi,

Luca Ceresoli wrote:
 > The recommended form is without the trailing slash. Buildroot will 
add a slash
 > between FOO_SITE and FOO_SOURCE as appropriate.
 >
 > This avoids the need for the $$($(2)_SITE:/=) magic in 
package/pkg-generic.mk
 > to avoid double slashes in download URLs, like
 > https://mosh.mit.edu//mosh-1.2.5.tar.gz which works but is dirty.
 >
 > Note: this work has already been done in b0b9606530dfc6de4030 a few 
months ago,
 > but no check has been added at that time to avoid new slashes to slip 
in, and
 > so they did. This time a patch will follow immediately to catch future
 > mistakes to be unnoticed.

And of course the last sentence should be written in English: "...to
prevent future mistakes from being unnoticed".

-- 
Luca



More information about the buildroot mailing list