[Buildroot] [PATCH v4 3/7] barebox: support custom barebox output image name
Pieter Smith
pieter at boesman.nl
Fri Apr 8 07:51:15 UTC 2016
On Thu, Apr 07, 2016 at 01:06:49AM +0200, Arnout Vandecappelle wrote:
> On 04/06/16 22:14, Pieter Smith wrote:
> >Hi Arnout / Thomas,
> >
> >On Tue, Apr 05, 2016 at 01:20:13AM +0200, Arnout Vandecappelle wrote:
> [snip]
> >> However, on second thought I'm wondering if it is really needed. For u-boot
> >>or the kernel, we always copy the images with the same name as they were
> >>built. If that is not what the ROM boot loader expects, the name can be
> >>changed in the image generation script. For example, genimage.cfg could
> >>contain:
> >>
> >>image boot.vfat {
> >> vfat {
> >> file MLO {
> >> "barebox-am33xx-beaglebone-mlo.img"
> >> }
> >> file barebox.img {
> >> "barebox-am33xx-beaglebone.img"
> >> }
> >> }
> >> size = 8M
> >>}
> >>
> >>
> >> What do you think?
> >
> >I agree that this is cleaner from a buildroot perspective. But this would
> >require carrying a genimage.cfg patch for barebox as part of
> >beaglebone_barebox_defconfig. Is this what you are suggesting?
>
> I don't really understand what you mean. As I suggested in that patch, it
> would be nice to add a genimage config as well. When you do that, you can
> use a fragment like above to make sure the files will have the correct name
> in the filesystem. (Like above, except I screwed up the indentation :-)
The vfat file attribute also expects an "image=" key, not just the image name.
Thanks! This will be in v5 of the patch-set.
[snip]
- Pieter Smith
More information about the buildroot
mailing list