[Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 13 21:53:17 UTC 2016


Hello,

On Mon,  4 Apr 2016 11:56:02 +0200, Julien Corjon wrote:
> Signed-off-by: Julien Corjon <corjon.j at ecagroup.com>
> ---
>  package/qt5/qt5connectivity/Config.in          | 10 ++++++----
>  package/qt5/qt5connectivity/qt5connectivity.mk |  4 +++-
>  2 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/package/qt5/qt5connectivity/Config.in b/package/qt5/qt5connectivity/Config.in
> index d529ea7..611ef14 100644
> --- a/package/qt5/qt5connectivity/Config.in
> +++ b/package/qt5/qt5connectivity/Config.in
> @@ -1,13 +1,15 @@
>  config BR2_PACKAGE_QT5CONNECTIVITY
>  	bool "qt5connectivity"
>  	select BR2_PACKAGE_BLUEZ_UTILS
> +	select BR2_PACKAGE_NEARD

So until now, neard was not necessary, and without any version bump or
anything, it should become a mandatory dependency? This seems weird,
and does not quite follow the policy of Buildroot that we should have
as much as possible the smallest set of mandatory dependencies.

Is it possible to have qt5connectivity with just Bluetooth support?
Just NFC support? No support for any of them at all?

I'm wondering if we shouldn't be doing:

ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y)
QT5CONNECTIVITY_DEPENDENCIES += bluez_utils
endif

ifeq ($(BR2_PACKAGE_NEARD),y)
QT5CONNECTIVITY_DEPENDENCIES += neard
endif

in the .mk file, instead of forcefully selecting both bluez_utils and
neard.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list