[Buildroot] [PATCH 3/4] linux-headers: rename _AS_KERNEL to _FROM_KERNEL

Vivien Didelot vivien.didelot at savoirfairelinux.com
Tue Apr 19 22:12:30 UTC 2016


Hi Thomas,

Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

>> BR2_KERNEL_HEADERS_AS_KERNEL is confusing when making the choice between
>> downloading the headers from an independent kernel source, and using the
>> headers found in the kernel built by Buildroot.
>> 
>> Rename it to BR2_KERNEL_HEADERS_FROM_KERNEL.
>> 
>> In the meantime, document this distinction between the two choices.
>> 
>> Signed-off-by: Vivien Didelot <vivien.didelot at savoirfairelinux.com>
>
> I tend to disagree here. The headers are not "from" the kernel, since
> in practice, we download the kernel source code twice and extract it
> twice. So the "as kernel" really seem better. It could be "like kernel"
> as well, but "from kernel" seems wrong.

So with BR2_KERNEL_HEADERS_AS_KERNEL, the kernel source tree to extract
the headers from is the same site as the Linux kernel source. With
!BR2_KERNEL_HEADERS_AS_KERNEL, the kernel source is downloaded from
kernel.org (or a mirror). Correct?

If yes, BR2_KERNEL_HEADERS_SAME_SOURCE or BR2_KERNEL_HEADERS_SAME_SITE
seem clearer to me.

> However, I'm all for improving the help texts to make this clearer.

Thanks,
Vivien



More information about the buildroot mailing list