[Buildroot] [PATCH v4 1/1] package/freeswitch: select OpenCV modules needed for mod_cv

Samuel Martin s.martin49 at gmail.com
Wed Apr 20 11:12:36 UTC 2016


Bernd, all,

On Tue, Apr 19, 2016 at 7:00 PM, Bernd Kuhls <bernd.kuhls at t-online.de> wrote:
> Fixes
> http://autobuild.buildroot.net/results/ffd/ffd572d7bb68d8ed46ce76b2af824503c587449f/
> http://autobuild.buildroot.net/results/e53/e53e356451aa4541a76e26722fd71051896e774b/
> http://autobuild.buildroot.net/results/564/5649ff1b50a1eaafbd0e1a329bff87a65ce18da0/
> http://autobuild.buildroot.net/results/c60/c60f97c6aafb1a94cb4ce344953598eae8b4a912/
> http://autobuild.buildroot.net/results/c1a/c1ac61f9a77635962babdb6bfb31dbecb7f4d439/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
> v4: add more suboptions (Samuel)
> v3: add more suboptions
> v2: select the required suboption instead of checking for its existance
>     in freeswitch.mk (Thomas)
>
>  package/freeswitch/Config.in | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/package/freeswitch/Config.in b/package/freeswitch/Config.in
> index 1350b2b..cef3fd4 100644
> --- a/package/freeswitch/Config.in
> +++ b/package/freeswitch/Config.in
> @@ -7,6 +7,17 @@ menuconfig BR2_PACKAGE_FREESWITCH
>         depends on BR2_USE_WCHAR # libuuid
>         select BR2_PACKAGE_LIBCURL
>         select BR2_PACKAGE_JPEG
> +       # src/mod/applications/mod_cv/mod_cv.cpp includes cv.h
and cvaux.h and cxmisc.h.
cvaux.h also pulls the photo module, which does not get selected
(either directly here or after via another opencv module in the
current state of the master).

Side note: freeswitch mixes deprecated legacy[1] and opencv2-style[2]
header include statement. Maybe just removing the legacy headers is
enough to not pull a (almost) full opencv, and reduce this select
list? but that's another question for freswitch upstream ;)

> +       select BR2_PACKAGE_OPENCV_LIB_CALIB3D if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_CONTRIB if BR2_PACKAGE_OPENCV
hum... where does the contrib module come from?

> +       select BR2_PACKAGE_OPENCV_LIB_FEATURES2D if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_FLANN if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_IMGPROC if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_LEGACY if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_OBJDETECT if BR2_PACKAGE_OPENCV
> +       select BR2_PACKAGE_OPENCV_LIB_VIDEO if BR2_PACKAGE_OPENCV
> +       # src/mod/applications/mod_cv/mod_cv.cpp includes highgui.h
> +       select BR2_PACKAGE_OPENCV_LIB_HIGHGUI if BR2_PACKAGE_OPENCV
>         select BR2_PACKAGE_OPENSSL
>         select BR2_PACKAGE_PCRE
>         select BR2_PACKAGE_SPEEX
> --
> 2.8.0.rc3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[1] https://freeswitch.org/stash/projects/FS/repos/freeswitch/browse/src/mod/applications/mod_cv/mod_cv.cpp#43
[2] https://freeswitch.org/stash/projects/FS/repos/freeswitch/browse/src/mod/applications/mod_cv/mod_cv.cpp#34

Regards,

-- 
Samuel



More information about the buildroot mailing list