[Buildroot] [PATCH 1/1] gst1-plugins-bad: hls: allow user to select crypto backend

[Peter Korsgaard]

>>>>> "Rahul" == Rahul Bedarkar <Rahul.Bedarkar at imgtec.com> writes:

Hi,

 >> I'm not sure I want to see a choice for this. Could we instead have
 >> the .mk file automatically selected the backend according to which
 >> crypto package(s) are available?

 > HLS plugin only supports above three crypto backends. If user hasn't
 > specified which backend to use then build system tries find nettle or
 > libgcrypt or openssl in order. If none of the backend is available
 > then HLS plugin gets disabled internally.

 > Automatically selecting the backend based on which crypto packages are
 > available, will work only if atleast one of supported crypto packages
 > are selected already. If none of the supported packages are available,
 > then we may need to add dependency on one of those crypto packages in
 > .mk without selecting them in Config.in. That looks like broken
 > dependency ?

Yes, but we can do something like (untested):

config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_HLS
        bool "hls"
        select BR2_PACKAGE_NETTLE if !(BR2_PACKAGE_GNUTLS || BR2_PACKAGE_OPENSSL)
        help
          Fragmented streaming plugins

and then in the .mk:

ifeq ($(BR2_PACKAGE_NETTLE),y)
GST1_PLUGINS_BAD_DEPENDENCIES += nettle
GST1_PLUGINS_BAD_CONF_OPTS += --with-hls-crypto=nettle
else ifeq ($(BR2_PACKAGE_GNUTLS),y)
GST1_PLUGINS_BAD_DEPENDENCIES += libgcrypt
GST1_PLUGINS_BAD_CONF_OPTS += --with-hls-crypto=libgcrypt \
	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
else
GST1_PLUGINS_BAD_DEPENDENCIES += openssl
GST1_PLUGINS_BAD_CONF_OPTS += --with-hls-crypto=openssl
endif

-- 
Bye, Peter Korsgaard