[Buildroot] [PATCH 2/2] tinycbor: fix issue on unnamed union

Fabrice Fontaine fontaine.fabrice at gmail.com
Tue Aug 16 20:57:58 UTC 2016


Dear Peter,

After more investigation, it seems that the uclibc for the blackfin target
is configured without __UCLIBC_HAS_GLIBC_CUSTOM_STREAMS__
(./output/host/opt/ext-toolchain/bfin-uclinux/bfin-uclinux/runtime/usr/include/bits/uClibc_config.h).
Without this option, fopencookie is not available in the toolchain and so
the implementation of open_memstream function within tinycbor fails so I
would suggest to disable tinycbor if BR2_bfin target is set.

If this solution is acceptable, I can provide a patch.

Best Regards,

Fabrice

2016-08-16 17:07 GMT+02:00 Peter Korsgaard <peter at korsgaard.com>:

> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
>
>  > Dear Peter,
>  > It seems that the link you provided is not correct as in this build,
>  > the old tinycbor 0.3.1 is being compiled.
>
> Yes, naturally - There won't be any autobuilder results for 0.3.2 before
> your patches get included in the buildroot repo.
>
> I was expecting your patches to fix some of our existing (E.G. using
> 0.3.1) autobuilder issues, but that is apparently not the case?
>
>  > Could you provide me the correct link so I can reproduce the issue? I
>  > suspect you encountered a totally new issue with src/open_memstream.c
>  > which is being compiled only if open_memstream is found in the
>  > toolchain but this file is also using fopencookie which does not seem
>  > to be available in the toolchain. If I can reproduce the issue, I
>  > will make a new patch to check the presence of fopencookie an send it
>  > upstream.
>
> You should be able to reproduce the issue if you build the defconfig
> from
>
> http://autobuild.buildroot.net/results/f4d/f4d15afb44f471878dbdee7c67cd83
> 6bd2b79904/
>
> After applying your 2 tinybcr patches.
>
>  > Concerning your original question, tinycbor 0.3.2 includes directly
>  > the patch from Thomas, more details can be found her:
>  > https://github.com/01org/tinycbor/commit/31c7f81d45d115d2007b1c881cbbd3
> a19618465c.
>
> Ok, so that means we can drop
> 0001-Makefile-use-installation-logic-compatible-with-old-.patch, good.
>
> > The second patch removes the unnamed union, more details can be found
> > here: https://patchwork.ozlabs.org/patch/652187/.
>
> Ok. It would be nice to mention that in the commit message.
>
> --
> Venlig hilsen,
> Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160816/fd24aa97/attachment-0002.html>


More information about the buildroot mailing list