[Buildroot] [PATCHv2] package/systemd: fix build with old toolchains
Baruch Siach
baruch at tkos.co.il
Tue Aug 30 09:35:11 UTC 2016
Hi Yann,
On Tue, Aug 30, 2016 at 11:29:37AM +0200, Yann E. MORIN wrote:
> Toolchains using glibc-2.18 or older do not define O_TMPFILE, which
> causes build failures on some archs.
>
> systemd has a definition for O_TMPFILE if it is missing, but only
> defines it for i386 or x86_64. Furthermore, the header defining it is
> not included everywhere O_TMPFILE is used.
>
> Fix that with three patches backported from upstream:
> - include the needed header where it is needed (he!),
> - define O_TMPFILE for all archs, according to linux-4.8rc3,
> - no longer guard against undefined O_TMPFILE in fileio.
This last patch is not a pure build fix, but more of a feature enhancement.
Don't know if it fits in master.
Also, your patches are missing sign-off.
An autobuild reference in the commit log would also be nice.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
More information about the buildroot
mailing list