[Buildroot] [PATCH 2/2] toolchain: simplify the conditions for BR2_TOOLCHAIN_ARM_HAS_SYNC_8
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Dec 8 21:44:47 UTC 2016
Hello,
On Fri, 25 Nov 2016 00:13:16 +0100, Arnout Vandecappelle wrote:
> > On Tue, 22 Nov 2016 00:43:40 +0100, Arnout Vandecappelle
> > (Essensium/Mind) wrote:
> >
> >> config BR2_TOOLCHAIN_ARM_HAS_SYNC_8
> >> bool
> >> default y
> >> depends on BR2_arm || BR2_armeb
> >> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> >> - depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_ARM_CPU_ARMV7A
> >> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> >
> > Can we make this instead:
> >
> > depends on (BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 && BR2_TOOLCHAIN_USES_GLIBC) || BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> >
> > This way, glibc toolchains (which were never affected by the _write
> > issue) still expose the fact that they support the __sync_8 thing.
> > Otherwise, your change introduces a regression: a 4.7 glibc external
> > toolchain was prior to your patch exposing the fact that it supports
> > 8-byte sync, but no longer after your patch.not-quite
>
> Now I think about it again, I think the condition should simply be
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
Could you submit a new version that does this?
I'll mark your patch as Changes Requested for the time being.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list