[Buildroot] [PATCH 1/1] nginx-dav-ext: New package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Dec 5 13:33:22 UTC 2016


Hello,

On Mon, 5 Dec 2016 14:20:43 +0100, Johan Oudinet wrote:

> Indeed, you have moved this module outside the HTTP modules:
> ifeq ($(BR2_PACKAGE_NGINX_HTTP),y)
> ...
> endif # BR2_PACKAGE_NGINX_HTTP
> 
> So now, linking fails if BR2_PACKAGE_NGINX_HTTP is not set.
> Should I rename this package to nginx-http-dav-ext to indicate it must
> be compiled with the HTTP server of nginx?

Hum, and the problem is I guess the same for the naxsi module. Renaming
the package name is not necessary, we should handle this using
dependencies.

The previous solution used for the nginx-naxsi package was not good,
because you could select BR2_PACKAGE_NGINX_NAXSI, but if
BR2_PACKAGE_NGINX_HTTP was disabled, in fact the naxsi module was not
built.

So instead, I believe that nginx-naxsi/Config.in and
nginx-dav-ext/Config.in should contain a:

	depends on BR2_PACKAGE_NGINX_HTTP

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list