[Buildroot] [Patch v2 3/9] s6: new package

Eric Le Bihan eric.le.bihan.dev at free.fr
Sun Dec 11 18:38:26 UTC 2016


Hi!

On 16-12-10 21:52:22, Thomas Petazzoni wrote:

[...]

> > +define S6_INSTALL_STAGING_CMDS
> > +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> > +endef
>
> You're doing a plain "make install" here.
>
> > +define HOST_S6_INSTALL_CMDS
> > +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
> > +		install-dynlib \
> > +		install-include
> > +endef
>
> but not here. Why?

The host variant of s6 builds some process supervision programs that I
deemed unuseful for the user, and only the libraries and headers are
needed to build the host variants of execline and s6-rc. But it is true
that this also applies to the staging directory. So, I'll use
"install-dynlib install-include" in this case too.

Thanks for the review.

--
ELB



More information about the buildroot mailing list