[Buildroot] [PATCH 1/1] gst1-vaapi: new package

[Jesper Bækdahl]

On 15 December 2016 at 21:47, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
>> --- /dev/null
>> +++ b/package/gstreamer1/gst1-vaapi/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_GST1_VAAPI
>> +     bool "gst1-vaapi"
>> +     select BR2_PACKAGE_GST1_PLUGINS_BASE
>> +     select BR2_PACKAGE_GST1_PLUGINS_BAD
>
> Are you sure you need those set of plugins to be built to build the
> gst1-vaapi plugin? I'm not too familiar with GStreamer, so maybe this
> is correct, but it looks strange.

I added them based on the requirements section found here:
https://github.com/01org/gstreamer-vaapi

>> +     select BR2_PACKAGE_GST1_PLUGINS_LIBVA
>> +     select BR2_PACKAGE_GST1_PLUGINS_LIBDRM
>
> These two lines however are clearly wrong: those symbols don't exist in
> Buildroot. And your .mk file has a dependency on libva and libdrm
> instead. So these should be:
>
>         select BR2_PACKAGE_LIBVA
>         select BR2_PACKAGE_LIBDRM

Will fix this.

> However, you need to inherit the dependencies of those packages:
>
>         depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm/libpthread-stubs
>         depends on !BR2_STATIC_LIBS

I will add those as dependencies too.


Best Regards,

Jesper Bækdahl
Hardware/Software Developer
Gamblify