[Buildroot] [PATCH 3/3] configs/firefly_rk3288: new board

Peter Korsgaard peter at korsgaard.com
Wed Feb 10 21:08:15 UTC 2016


>>>>> "Ariel" == Ariel D'Alessandro <ariel at vanguardiasur.com.ar> writes:

 > Signed-off-by: Ariel D'Alessandro <ariel at vanguardiasur.com.ar>
 > ---
 >  configs/firefly_rk3288_defconfig | 40 ++++++++++++++++++++++++++++++++++++++++
 >  1 file changed, 40 insertions(+)
 >  create mode 100644 configs/firefly_rk3288_defconfig

 > diff --git a/configs/firefly_rk3288_defconfig b/configs/firefly_rk3288_defconfig
 > new file mode 100644
 > index 0000000..28becfd
 > --- /dev/null
 > +++ b/configs/firefly_rk3288_defconfig
 > @@ -0,0 +1,40 @@
 > +BR2_arm=y
 > +BR2_cortex_a15=y
 > +BR2_ARM_FPU_NEON_VFPV4=y
 > +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
 > +BR2_TOOLCHAIN_BUILDROOT_CXX=y

Our defconfigs are normally very minimal, E.G. only a basic busybox
based image and a kernel/bootloader - In other words the basics to start
your own development from.

There has been some discussion about doing more full blown "demo"
defconfigs, so I'm fine with adding a more complicated
firefly_rk3288_demo_defconfig in addition to the basic one.


 > +BR2_TARGET_GENERIC_HOSTNAME="firefly-rk3288"
 > +BR2_TARGET_GENERIC_ISSUE="Welcome to FIREFLY RK3288!"
 > +BR2_TARGET_GENERIC_GETTY_PORT="/dev/console"

The /dev/ should afaik not be there and we default to "console" already,
so this can be dropped.

> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/firefly-rk3288/pre-image.sh"
 > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/firefly/firefly-rk3288/post-image.sh"
 > +BR2_LINUX_KERNEL=y
 > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
 > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git at github.com:mmind/linux-rockchip.git"
 > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="ccb89e9b5657b4911c16d08e1581121222ee12c4"

Will this commit stay available or is this a branch that gets rebased?

What kernel version is this? I see you don't set the kernel-headers
version.

> +BR2_LINUX_KERNEL_DEFCONFIG="rk3288_veyron"
 > +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
 > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
 > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-firefly"
 > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
 > +BR2_PACKAGE_QT5=y
 > +BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
 > +BR2_PACKAGE_QT5BASE_EXAMPLES=y
 > +BR2_PACKAGE_QT5BASE_GUI=y
 > +BR2_PACKAGE_QT5BASE_EGLFS=y
 > +BR2_PACKAGE_MALI_T76X=y
 > +BR2_TARGET_ROOTFS_EXT2=y
 > +BR2_TARGET_ROOTFS_EXT2_4=y
 > +# BR2_TARGET_ROOTFS_TAR is not set
 > +BR2_TARGET_UBOOT=y
 > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
 > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.denx.de/u-boot.git"
 > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2016.01"

As this is mainline u-boot you can simply set:

BR2_TARGET_UBOOT_CUSTOM_VERSION=y
BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.01"

And Buildroot will download the 2016.01 tarball.

Other than that it looks good, thanks. Care to send updated patches
fixing these issues?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list