[Buildroot] [PATCH] yad: fix libgtk3 dependency
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Feb 7 22:32:41 UTC 2016
Dear Gustavo Zacarias,
On Wed, 3 Feb 2016 10:01:55 -0300, Gustavo Zacarias wrote:
> Make it depend explicitly on BR2_PACKAGE_LIBGTK3_X11 (the X11 backend
> option) to avoid the checker from complaining.
> Also add a comment about yad requiring the X11 backend otherwise it's
> ambiguous if a user has libgtk3 enabled with broadway/wayland and the
> comment shows up. Fixes:
> http://autobuild.buildroot.net/results/84d/84d97bbcc0ea4f8eaa50dd25bf9ee8fdee4b937f/
>
> Also cleanup some tiny whitespace in the package mk file.
>
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
Applied, but see one question below.
> ---
> package/yad/Config.in | 6 +++---
> package/yad/yad.mk | 1 -
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/package/yad/Config.in b/package/yad/Config.in
> index e4b63a2..50b97c5 100644
> --- a/package/yad/Config.in
> +++ b/package/yad/Config.in
> @@ -1,13 +1,13 @@
> config BR2_PACKAGE_YAD
> bool "yad"
> depends on BR2_PACKAGE_XORG7
> - depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> + depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11
Is the BR2_PACKAGE_XORG7 dependency still needed, then?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list