[Buildroot] [PATCH] sysklogd: override SKFLAGS with TARGET_CFLAGS
Peter Korsgaard
peter at korsgaard.com
Sun Feb 21 09:21:53 UTC 2016
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
Hi,
>> +# Override SKFLAGS which is used as CFLAGS.
>> define SYSKLOGD_BUILD_CMDS
>> - $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>> + $(MAKE) $(TARGET_CONFIGURE_OPTS) SKFLAGS="$(TARGET_CFLAGS) -DSYSV" \
> Doesn't that make the bug above reappear when you have configured
> BR2_OPTIMIZE_3? In other words, shouldn't we do something like:
> ifeq ($(BR2_TOOLCHAIN...),y)
> SYSKLOGD_CFLAGS = $(subst -O3,-O2,$(TARGET_CFLAGS))
> else
> SYSKLOGD_CFLAGS = $(TARGET_CFLAGS)
> endif
> SYSKLOGD_CFLAGS += -DSYSV
True, but chances are that other packages will be affected by that -O3
issue with the 2012.03, so perhaps the safest option is to make
BR2_OPTIMIZE_3 depend on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC_E500V2.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list