[Buildroot] [PATCH v2 1/1] package/avahi: add optional support for libcap
Peter Korsgaard
peter at korsgaard.com
Sun Feb 21 20:43:00 UTC 2016
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
> Dear Bernd Kuhls,
> On Sun, 21 Feb 2016 18:57:19 +0100, Bernd Kuhls wrote:
>> When libcap was compiled before, avahi daemon will use it as optional
>> dependency:
>>
>> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/avahi-daemon | grep NEEDED | sort
>> 0x0000000000000001 (NEEDED) Shared library: [libavahi-common.so.3]
>> 0x0000000000000001 (NEEDED) Shared library: [libavahi-core.so.7]
>> 0x0000000000000001 (NEEDED) Shared library: [libcap.so.2]
>> [...]
>>
>> The build system offers no option to en-/disable libcap support:
>> http://git.0pointer.net/avahi.git/tree/configure.ac#n382
>>
>> The check for libcap was placed inside the BR2_PACKAGE_AVAHI_DAEMON
>> because only avahi-daemon uses libcap, it provides chroot support.
> Still, the configure.ac test is done unconditionally (i.e regardless
> of whether the daemon is enabled or not), so I believe we should also
> do the same.
> Peter, Yann, Arnout, your thoughts?
It's safer to do it unconditionally (and we are unlikely to have
problems with dependency loops with avahi/libcap, so that's not an issue
either).
So I would prefer to have it outside the _DAEMON conditional as well.
--
Venlig hilsen,
Peter Korsgaard
More information about the buildroot
mailing list