[Buildroot] [PATCH] msr-tools: new package

Vincent Stehlé vincent.stehle at intel.com
Mon Feb 22 22:21:52 UTC 2016


Hi Yegor,

Thank you very much for your review!

On Mon, Feb 22, 2016 at 03:40:59PM +0100, Yegor Yefremov wrote:
> 
> Config.in is missing a depends message like this:
> 
> comment "msr-tools runs only on x86 CPUs"
>         depends on !BR2_i386 && !BR2_x86_64

Good idea; I'll add that.

..
> > +MSR_TOOLS_SOURCE = msr-tools-$(MSR_TOOLS_VERSION).tar.gz
> 
> Do you really need MSR_TOOLS_SOURCE?

And you are right again: this is definitely not necessary to repeat the default
source name :)

Thanks for spotting those; I'll send a v2 right away.

Best regards,

Vincent.



More information about the buildroot mailing list