[Buildroot] [PATCH] sox: disable SSP when using MIPS Codescape toolchains

[Thomas Petazzoni]

Vicente,

On Mon, 29 Feb 2016 16:39:42 +0000, Vicente Olivert Riera wrote:

> diff --git a/package/sox/sox.mk b/package/sox/sox.mk
> index f4d1608..61f5220 100644
> --- a/package/sox/sox.mk
> +++ b/package/sox/sox.mk
> @@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
>  SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
>  SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
>  
> +# MIPS Codescape toolchains don't support stack-smashing protection
> +# despite of using glibc.
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
> +SOX_CONF_OPTS += --disable-stack-protector
> +endif

Shouldn't we instead change BR2_TOOLCHAIN_HAS_SSP so that it is defined
to false for those toolchains? This way:

 1/ The existing BR2_TOOLCHAIN_HAS_SSP tests would do the right thing
    for the Codescape toolchains.

 2/ The additional test you are adding would also be useful for other
    non-SSP capable toolchains.

That being said, we're very close to 2016.02, so I'm not sure this will
get into 2016.02. If the folks releasing the Codescape toolchain
release soon a version which has a properly working SSP implementation,
then we could simply forget about this problem until they make this
release. If of course such a new toolchain version is not planned in
the near future, we would need to fix the problem.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com