[Buildroot] [PATCH v3 09/13] package/dhcp: SysV init scripts: remove PID files after stop

[Benoît Thébaudeau]

Thomas,

On Thu, Dec 24, 2015 at 3:26 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> On Sun, 25 Oct 2015 02:59:35 +0200, Benoît Thébaudeau wrote:
>> From: Benoît Thébaudeau <benoit at wsystem.com>
>>
>> These daemons do not remove their PID files, so do it manually in the
>> scripts.
>>
>> Signed-off-by: Benoît Thébaudeau <benoit at wsystem.com>
>
> I think this is not the right way of handling this and the IPv6
> problem.
>
> What I would suggest is that the S80dhcp-server script should start two
> DHCP servers: one with -4 and one with -6. To avoid IPv6 failures, you
> can test if /proc/net/if_inet6 exists.

OK, I'll do that.

> Then, I was hoping you could use the --remove-pidfile option of
> start-stop-daemon, but it unfortunately doesn't exist in the Busybox
> implementation of start-stop-daemon.

Indeed. I also went that way first. So what are you eventually
suggesting to change for 09/13 since there is apparently no other
solution for SysV? Even with two daemons started, the PID files will
have to be removed with rm for SysV, so 09/13 would only have to be
split. This is already handled for systemd.

> That being said, I still believe starting two daemons is the best
> solution. I don't think a Config.in option should be added for that.
> Just always start both, with as I propose an exception to not start the
> IPv6 daemon if /proc/net/if_inet6 does not exist.
>
> Could you rework your patches 9 to 13 with this goal in mind ?
>
> Thanks a lot!

Will do.

Benoît