[Buildroot] [PATCH 01/21] libftdi: C++ bindings need boost

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jan 25 20:04:20 UTC 2016


Hello,

On Mon, 25 Jan 2016 18:04:38 +0100, Yann E. MORIN wrote:

> >  config BR2_PACKAGE_LIBTFDI_CPP
> > -	depends on BR2_INSTALL_LIBSTDCPP
> >  	bool "C++ bindings"
> > +	depends on BR2_INSTALL_LIBSTDCPP
> > +	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
> > +	depends on BR2_USE_WCHAR
> > +	select BR2_PACKAGE_BOOST
> 
> boost also has a threads dependency, but that is covered by the main
> symbol, because of libusb.
> 
> I wonder if we should duplicate the dependency here, with another
> comment, like:
> 
>     depends on BR2_TOOLCHAIN_HAS_THREADS # Boost
> 
> Or at least state it in a comment:
> 
>     # Boost depends on threads, but that's already accounted for
>     # in the main symbol because of libusb.

We don't have clear rules about what to do in such situations. We
sometimes say to duplicate the dependencies, but sometimes it looks
really really annoying to duplicate all those dependencies when you
*know* that the top-level package can anyway not be enabled in this or
that situation.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list