[Buildroot] [PATCH 2/2] crudini: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jan 26 21:56:29 UTC 2016


Dear Zoltan Gyarmati,

On Sun, 24 Jan 2016 01:15:04 +0100, Zoltan Gyarmati wrote:

> diff --git a/package/crudini/Config.in b/package/crudini/Config.in
> new file mode 100644
> index 0000000..c677f3b
> --- /dev/null
> +++ b/package/crudini/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_CRUDINI
> +	depends on BR2_PACKAGE_PYTHON
> +	select BR2_PACKAGE_PYTHON_INIPARSE
> +	bool "crudini"

See the documentation which has been recently updated on the ordering
of properties:

+As a convention specific to Buildroot, the ordering of the attributes
+is as follows:
+
+1. The type of option: +bool+, +string+... with the prompt
+2. If needed, the +default+ value(s)
+3. Any dependency of the +depends on+ form
+4. Any dependency of the +select+ form
+5. The help keyword and help text.

Also, please indicate above the select BR2_PACKAGE_PYTHON_INIPARSE that
this is a runtime dependency.

> +	help
> +	  A utility for handling ini files from the command line and shell scripts

Wrap at 72 characters.

> diff --git a/package/crudini/crudini.hash b/package/crudini/crudini.hash
> new file mode 100644
> index 0000000..04e2575
> --- /dev/null
> +++ b/package/crudini/crudini.hash
> @@ -0,0 +1,2 @@
> +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=7d1313f1bb9800db9cbceaa518bcf212
> +md5    7d1313f1bb9800db9cbceaa518bcf212 crudini-0.7.tar.gz

sha256 hash needed.

Other than that, looks good! Can you fix the minor issues above and
resubmit an updated version?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list