[Buildroot] [PATCH 07/21] pulseaudio: remove BR2_ARCH_HAS_ATOMICS dependency
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Jan 27 23:01:31 UTC 2016
Hello,
On Wed, 27 Jan 2016 23:51:06 +0100, Yann E. MORIN wrote:
> > I intentionally kept the json-c and pulseaudio patches separate. The
> > json-c patch only adds the additional BR2_TOOLCHAIN_HAS_SYNC_4
> > dependency to json-c and all its reverse dependencies, keeping the
> > BR2_ARCH_HAS_ATOMICS when they existed.
> >
> > This patch then removes the BR2_ARCH_HAS_ATOMICS where they are no
> > longer needed.
> >
> > I think it remains bisectable, and allows to kept the patches somewhat
> > saner in size than the cairo one.
>
> Sorry, what I meant was that the 'depends on BR2_TOOLCHAIN_HAS_SYNC_4'
> on the comment should have been added in the previous commit, i.e. at
> the time json-c gains the _SYNC_4 dependency.
>
> Then in this very commit, you can indeed 'just' remove the _HAS_ATOMICS
> dependency.
Hum, right, I see what you mean. Indeed, I should fix that, it's not
consistent. I'll wait for some other review on the v2, and I'll respin.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list