[Buildroot] [PATCH v3 2/2] gcc: apply patches stored in global patches directories

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 3 13:53:09 UTC 2016


Hello,

On Wed, 13 Apr 2016 04:20:32 +0000, Chunhui He wrote:
> When building host gcc, patches stored in global patches directories
> are skipped.
> This patch fixes the unexpected behavior.
> 
> Signed-off-by: Chunhui He <hchunhui at mail.ustc.edu.cn>
> ---
>  package/gcc/gcc.mk | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)

We had some pretty lengthy discussion today with Peter and Yann about
this patch, arguing about the various possibilities to solve this
problem. In the end, even though your solution is a bit of a hack, it's
the one that is the easiest in terms of on-going maintenance, so I
applied your patch after doing some minor modifications:

    [Thomas:
     - rename the loop variable from 'D' to 'patchdir'
     - add some additional comments
     - remove final ; at end of loop when applying the patches, since it's
       not needed]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list