[Buildroot] [PATCH v4 4/7] package/ffmpeg: default to --cpu=generic for MIPS architecture

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls at t-online.de> writes:

 > From: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
 > This option is needed to prevent this message from configure:

 > WARNING: unknown CPU. Disabling all MIPS optimizations.

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
 > Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
 > ---
 > v4: no changes
 > v3: no changes
 > v2: no changes

 >  package/ffmpeg/ffmpeg.mk | 5 +++++
 >  1 file changed, 5 insertions(+)

 > diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
 > index 08914b8..418893f 100644
 > --- a/package/ffmpeg/ffmpeg.mk
 > +++ b/package/ffmpeg/ffmpeg.mk
 > @@ -445,6 +445,11 @@ else ifneq ($(call qstrip,$(BR2_GCC_TARGET_ARCH)),)
 >  FFMPEG_CONF_OPTS += --cpu=$(BR2_GCC_TARGET_ARCH)
 >  endif
 
 > +# Default to --cpu=generic for MIPS architecture
 > +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
 > +FFMPEG_CONF_OPTS += --cpu=generic
 > +endif

This is not really about "defaulting" to it, as the logic really
enforces it. From looking at the upstream configure script passing this
means that we explicitly need to pass --enable/--disable for the MIPS
sub options:

https://github.com/FFmpeg/FFmpeg/blob/master/configure#L4406

> +
 >  FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF))
 
 >  # Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others
 > -- 
 > 2.8.1

 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard