[Buildroot] [PATCH v3] package/quagga: Add systemd.service file

[Nathaniel Roach]

Ah, another case of me misinterpreting defaults. This can also be removed if it's preferred to leave it as default.

On 3 July 2016 9:09:39 PM AWST, Maxime Hadjinlian <maxime.hadjinlian at gmail.com> wrote:
>On Sun, Jul 3, 2016 at 3:06 PM, Nathaniel Roach <nroach44 at gmail.com>
>wrote:
>> Oh, and it's not 0 such that it won't restart and hog resources quite
>as
>> badly if it's instantly dieing.
>>
>The default is 100ms, do you think that's still too fast ? Usually
>it's enough but if you encounter problem and 1s is the shortest it can
>do, then 1s it is.
>
>Other than that:
>Reviewed-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
>[...]
>>>>>> +EnvironmentFile=/etc/default/quagga-%i
>>>>>> +PrivateTmp=true
>>>>>> +# Systemd doesn't like having %i in the executable path.
>>>>>> +ExecStart=/usr/bin/env /usr/sbin/%i $OPTS -f /etc/quagga/%i.conf
>>>>>> +ExecReload=/bin/kill -HUP $MAINPID
>>>>>> +KillMode=mixed
>>>>>> +KillSignal=SIGINT
>>>>>
>>>>> If I understand correctly, what you want to do is send a SIGINT to
>the
>>>>> main processes and SIGKILL to the other ? From the services file I
>can
>>>>> find in major distro, they don't specify it so it's left to the
>>>>> default SIGTERM, why did you need to change that ? (Maybe you
>already
>>>>> explained in your previous mail and I missed, sorry if that's the
>>>>> case).
>>>>
>>>> KillMode=Mixed is an artefact left over from the OpenVPN .service
>file I
>>>> used as a reference. I (again) misread the systemd docs and left it
>in as
>>>> it
>>>> seemed more appropriate than the default if any child processes are
>>>> started.
>>>> This can be removed on commit, or I'll fix it if there's any other
>things
>>>> that need to be changed.
>[...]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160703/7807af0b/attachment-0002.html>