[Buildroot] [V2] 4th: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jul 5 20:41:52 UTC 2016


Hello,

When doing a new iteration of a patch, please add a changelog that
indicates what has been changed.

On Tue,  5 Jul 2016 21:05:20 +0200, Francois Perrad wrote:

> +4TH_VERSION = 3.62.4
> +4TH_SOURCE = 4th-$(4TH_VERSION)-unix.tar.gz
> +4TH_SITE = http://downloads.sourceforge.net/project/forth-4th/4th-$(4TH_VERSION)
> +4TH_LICENSE = GPLv3, LGPLv3
> +4TH_LICENSE_FILES = COPYING

Did you resolve the licensing issue? That was the main point of my
previous review:

"""
I was about to apply your patch, with some minimal changes (see
http://code.bulix.org/i2s65n-101064), but there is one fundamental
license issue here.

The COPYING file, as well as documentation/license.txt contain the
license text of the LGPLv3. But the source code (sources/*.c) all claim
to be licensed under the GPLv3. Only the .4th files are under LGPLv3.

This is clearly not good. Could you talk with upstream to get this
situation resolved?
"""

At least some reply from you about this would have been useful to
understand what's going on.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list