[Buildroot] [PATCH 2/3] package/protoc-gen-lua: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jul 16 10:36:04 UTC 2016


Hello,

On Thu, 30 Jun 2016 09:53:37 -0300, Tiago Brusamarello wrote:

> +define HOST_PROTOC_GEN_LUA_INSTALL_CMDS
> +	# install protoc Lua plugin

Please put this comment above the variable definition.

> +	$(INSTALL) -m 0755 $(@D)/protoc-plugin/plugin_pb2.py $(HOST_DIR)/usr/bin
> +	$(INSTALL) -m 0755 $(@D)/protoc-plugin/protoc-gen-lua $(HOST_DIR)/usr/bin

Please use:

	$(INSTALL) -D -m 0755 $(@D)/protoc-plugin/protoc-gen-lua $(HOST_DIR)/usr/bin/protoc-gen-lua

(for both files)

I.e: use the -D option, and specify a full destination path.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list