[Buildroot] [PATCH v2] toolchain: add hidden symbol for PIE support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 24 19:47:40 UTC 2016


Hello,

On Sun, 24 Jul 2016 17:06:17 +0200, Romain Naour wrote:

> >  config BR2_TOOLCHAIN_USES_UCLIBC
> >  	bool
> > +	select BR2_TOOLCHAIN_SUPPORTS_PIE if !BR2_arc && !BR2_m68k && !BR2_STATIC_LIBS  
> 
> It seems that we also need to black list ARM + uClibc + static linking config [1]

Isn't it blacklisted above? Waldemar's code will select
BR2_TOOLCHAIN_SUPPORTS_PIE only if we are not on ARC *and* we are not
on m68k *and* we are not static linking.

So if you're static linking, !BR2_arc && !BR2_m68k && !BR2_STATIC_LIBS
is false, and BR2_TOOLCHAIN_SUPPORTS_PIE is not selected.

> Also, what about a test in the toolchain helper to check PIE support is really
> available ?

Would be nice, but I'm not sure it's that easy: in practice a simple
executable will build with -fPIE on ARC, but more complicated piece of
code will not.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list