[Buildroot] [PATCH] nettle: disable assembly optimizations for ARMv7M
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Jul 25 20:48:44 UTC 2016
Hello,
On Sun, 24 Jul 2016 21:15:59 -0300, Gustavo Zacarias wrote:
> It's thumb2-only and it requires ARM instructions.
> Since V4 and V5 aren't enough either use the V7M knob to avoid
> over-complicating the conditional. Fixes:
> http://autobuild.buildroot.net/results/354/35418d33efa902d3a1a82b2cd58d8db1b1172e49/
>
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> ---
> package/nettle/nettle.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nettle/nettle.mk b/package/nettle/nettle.mk
> index c133839..a94a7fc 100644
> --- a/package/nettle/nettle.mk
> +++ b/package/nettle/nettle.mk
> @@ -15,7 +15,7 @@ NETTLE_LICENSE_FILES = COPYING.LESSERv3 COPYINGv2
> NETTLE_CONF_OPTS = --disable-openssl
>
> # ARM assembly requires v6+ ISA
> -ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5),y)
> +ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV7M),y)
I've applied, but in the end, I'm wondering if the condition wouldn't
be simpler as:
ifeq ($(BR2_ARM_CPU_ARMV6)$(BR2_ARM_CPU_ARMV6),)
NETTLE_CONF_OPTS += --disable-assembler
endif
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list