[Buildroot] [PATCH v5] package/radlib: new package

[Kinsella, Ray]

apologies for the delay in replying.

On 02/05/2016 21:44, Arnout Vandecappelle wrote:
> On 04/24/16 17:15, Kinsella, Ray wrote:
>> Thanks Arnout,
>>
>> See inline.
>>
>> On Fri, 2016-04-22 at 01:02 +0200, Arnout Vandecappelle wrote:
> [snip]
>>>   I think this should be the first patch; our autoreconf will not be
>>> happy
>>> without subdir-objects.
>
>  Actually, this was a silly argument: our build will only work with all
> patches applied, of course.

understood.

>
>>
>> autoreconf does complain without the subdir-objects. The removal of the
>> CROSS_COMPILE in the same patch is important as the linker breaks
>> without it. It won't even get to linking stage if it can't find the
>> various database libraries fixed in the two previous patches.
>>
>> Suggest a new first patch to fix sudir-objects (patch number 4.), but
>> then leave the other patches as they are. So the flow would be.
>>
>> 1. Fix subdir-objects
>> 2. Fix sqlite + postgresql
>> 3. Fix mysql
>> 4. Fix the linker (CROSS_COMPILE).
>>
>> What do you think?
>
>  That sounds good. Perhaps 2+3 could be combined, it doesn't matter that
> much.
>
>
> [snip]
>>>   I'm not really happy with this choice, I'd prefer an automatic
>>> selection. But
>>> it's true, if both mysql and postgresql are selected it's hard to
>>> decide which
>>> one should be used...
>>
>> sent a seperate email on this.
>> mysql and postgresql are mutually exclusive.
>> sqlite lite can be safely enabled/disable depending on
>> BR2_PACKAGE_SQLITE.
>
>  Still, I'd prefer an automatic selection. E.g. if mysql is selected,
> build mysql support, else if pgsql is selected, build pgsql support,
> else disable both.

ok - that will mean there is always an implicit bias for mysql.
I am fine with that being the case.

>
>
> [snip]
>
>
>  Regards,
>  Arnout
>