[Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod
Peter Korsgaard
peter at korsgaard.com
Mon Jun 6 21:01:45 UTC 2016
>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
> When that was added (in 975e30b, fs/squashfs: fix image file
> permissions), the reasons were not quite explicit.
The git hash is wrong, it was 3975e30b9.
> We are now forcing the umask, and various tests have shown that the mode
> on the generated image file are correct without the chmod.
> Remove it.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Peter Korsgaard <peter at korsgaard.com>
otherwise it looks good.
Acked-by: Peter Korsgaard <peter at korsgaard.com>
> ---
> fs/squashfs/squashfs.mk | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/fs/squashfs/squashfs.mk b/fs/squashfs/squashfs.mk
> index eadbb8f..c4d9ca5 100644
> --- a/fs/squashfs/squashfs.mk
> +++ b/fs/squashfs/squashfs.mk
> @@ -27,7 +27,6 @@ endif
> define ROOTFS_SQUASHFS_CMD
> $(HOST_DIR)/usr/bin/mksquashfs $(TARGET_DIR) $@ -noappend \
> $(ROOTFS_SQUASHFS_ARGS)
> - chmod 0644 $@
> endef
> $(eval $(call ROOTFS_TARGET,squashfs))
> --
> 2.7.4
--
Venlig hilsen,
Peter Korsgaard
More information about the buildroot
mailing list