[Buildroot] Patchwork cleanup week #24
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Jun 16 07:32:09 UTC 2016
Thomas,
Thanks for giving some feedback!
On Thu, 16 Jun 2016 09:18:37 +0200, Thomas De Schampheleire wrote:
> [..]
> > 6. wget download: 'scheme missing' results in empty output file
> > http://patchwork.ozlabs.org/patch/599387/
> >
>
> The mail thread where this patch originated from is at:
> http://lists.busybox.net/pipermail/buildroot/2016-February/153953.html
>
> There was no further response on this patch, but as far as I'm
> concerned the issue is still present and could use a fix.
>
> What do you think about the proposed solution?
I am not sure what is the best solution between:
- Defining <foo>_SITE to undefined when no value is specified by the
package (which is your proposal)
- Do not add to <pkg>_ALL_DOWNLOADS the files for which there is
no :// in the URL, and <pkg>_SITE is empty. This was the proposal
made by Yann in
http://lists.busybox.net/pipermail/buildroot/2016-February/153999.html.
- Error out when both <pkg>_SITE is empty and <pkg>_SOURCE is
non-empty.
In any case, the patch in patchwork is not applicable as-is, as it
doesn't contain a proper description + SoB line.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list