[Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jun 18 20:58:01 UTC 2016


Hello,

On Sat, 18 Jun 2016 17:43:26 +0100, Vicente Olivert Riera wrote:

>  # sparc64 needs -fPIC instead of -fpic
>  ifeq ($(BR2_sparc64),y)
> -ELFUTILS_CFLAGS += -fPIC
> +ELFUTILS_CFLAGS = -fPIC

This change is wrong, += should be kept here.

>  # elfutils gets confused when lfs mode is forced, so don't
> -ELFUTILS_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> +ELFUTILS_CFLAGS += $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))

Either you change to += like you propose, or you move the assignment
earlier. Changing to += is fine for me, but you should not change the
conditional assignment to = in the sparc64 condition.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list