[Buildroot] [PATCH] toolchain: also source the musl package
Peter Korsgaard
peter at korsgaard.com
Tue Mar 8 21:00:49 UTC 2016
>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
> We do source the glibc and uClibc packages in the toolchain menu,
> because they do provide user-visible options. However, we do not so
> far source the musl Config.in file
> However, in 822be87 (toolchain: include C libraries in legal-info),
> a Config.in file for musl was explicitly created, so that:
> - legal-info woudl work (needed at the time, probably no longer needed
> nowadays),
> - the appropriate packages are enabled, linke netbsd-queue or kernel
> headers.
> Yet, we do not source musl/Config.in, which means we do not get
> netbsd-queue or kernel-headers to be selected:
> $ make distclean; make menuconfig
> Toolchain --->
> C library ---> musl
> save-and-exit
> $ grep BR2_PACKAGE_LINUX_HEADERS .config
> [nothing]
> $ grep BR2_PACKAGE_NETBSD_QUEUE .config
> [nothing]
> Fix that by sourcing musl/Config.in at the same place we source glibc
> and uClibc.
> Normally, we do have a check in place that verifies that a package
> that is not enabled is not a dependency of another package that is
> enabled. However, musl is only a dependency of host-gcc-final, which
> is a host package and has no corresponding BR2_PACKAGE_HOST_GCC_FINAL.
> Thus host-gcc-final is not in the PACKAGES variable, and thus does not
> trigger our check.
> Reported-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list