[Buildroot] [PATCH 5/8] linux: add the generic help rules

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Mar 10 10:12:00 UTC 2016


Hello,

On Thu, 10 Mar 2016 10:52:03 +0100, Arnout Vandecappelle wrote:

>   This bit could easily be done in generic-package. I definitely don't like 
> direct manipulation of global variables in a package.mk.

You mean like TARGET_FINALIZE_HOOKS ? :-)

package/google-breakpad/google-breakpad.mk:TARGET_FINALIZE_HOOKS += GOOGLE_BREAKPAD_EXTRACT_SYMBOLS
package/luarocks/luarocks.mk:TARGET_FINALIZE_HOOKS += LUAROCKS_FINALIZE_TARGET
package/perl/perl.mk:TARGET_FINALIZE_HOOKS += PERL_FINALIZE_TARGET
package/python/python.mk:TARGET_FINALIZE_HOOKS += PYTHON_FINALIZE_TARGET
package/python3/python3.mk:TARGET_FINALIZE_HOOKS += PYTHON3_FINALIZE_TARGET
...

>   It's incredible how much discussion we have about such a corner feature :-)
> I guess we just need _something_ to disagree about :-P

Yes, I agree it's incredible. But I personally don't like Yann's
solution, it is too much over-engineered IMO, and is in fact less
flexible than simpler solutions.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list