[Buildroot] [PATCH v7 02/18] core: use $(CURDIR) to set TOPDIR

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Mar 10 20:45:45 UTC 2016


Hello,

On Thu, 10 Mar 2016 00:51:11 +0100, Arnout Vandecappelle wrote:
> On 03/09/16 23:58, Samuel Martin wrote:
> > This changes saves a shell call and uses a variable automatically set
> > by make [1].
> 
>   Wouldn't it be better to just use $(CURDIR) everywhere then?

We could but I personally find TOPDIR to be clearer: it clearly
identifies the top-level directory of the Buildroot source tree. While
CURDIR could easily be mistaken as something else.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list