[Buildroot] [PATCH 07/16] musl: build broken on Thumb, use ARM mode

[Thomas Petazzoni]

Hello,

On Thu, 17 Mar 2016 00:14:01 +0100, Arnout Vandecappelle wrote:

> > +# Thumb build is broken, build in ARM mode
> 
>   The comment about all our thumb1 architectures supporting arm mode should be 
> repeated here IMHO.
> 
> > +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> 
>   So this one would also have to be changed if INSTRUCTIONS_THUMB2 is removed. 
> Hm, maybe not such a good idea after all... So instead, just add a depends on 
> !THUMB2 to BR2_ARM_INSTRUCTIONS_THUMB.

Aah, so you come to the same conclusion as me: keeping
BR2_ARM_INSTRUCTIONS_THUMB *and* BR2_ARM_INSTRUCTIONS_THUMB2 is
simpler :-)

The depends on !BR2_ARM_CPU_HAS_THUMB2 indeed needs to be added to
BR2_ARM_INSTRUCTIONS_THUMB if we change BR2_ARM_CPU_HAS_THUMB2 to make
it select BR2_ARM_CPU_HAS_THUMB. IMO, this is a rather useless change,
since in practice, you don't care that Thumb2 is a superset of Thumb:
you will only allow Thumb2 for Thumb2-capable cores, and only allow
Thumb for Thumb-capable cores.

But if you like it, I'm happy to do this useless change :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com