[Buildroot] [PATCH v2] radlib: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Mar 29 21:51:53 UTC 2016


Hello,

On Tue, 29 Mar 2016 21:35:37 +0000, Kinsella, Ray wrote:
> > Please use git send-email to send your patches. Due to not using git
> > send-email, your e-mail is badly line-wrapped and cannot be applied,
> > and even less reviewed nicely.
> 
> ok - I will figure out the smtp setup. 

Plenty of @intel.com people contribute to the kernel, and use git
send-email. So I'm sure you can find the appropriate SMTP setup :)


> > This should go below the "---" sign.
> 
> ok the 'Delta's from v1:-' should be moved after the Signed-off-by
> line?

After the --- separator that follows the SoB line.

> > So you're doing three different things. Which calls for three
> > different
> > patches.
> 
> Hopefully this won't require me to re-org the patch. 

Well, you'll have to split your "big" patch into three smaller patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list