[Buildroot] [PATCH] norm: fix build failure with old headers

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Mar 31 16:30:31 UTC 2016


Hello,

On Thu, 31 Mar 2016 13:23:01 -0300, Gustavo Zacarias wrote:

> Indeed it's probably not acceptable for old netfilter_queue 
> compatibility, though i made it the quick way since it was polluting the 
> autobuilders.

Sure. That's also why I applied.

> It's waf, my famous friend, i'll try to cook up a failproof test for it, 
> unfortunately netfilter_queue doesn't version the API in a visible way, 
> so maybe a pkg-config though i need to consult the author/maintainer 
> since it would be a new dependency to build.

I think version-based checks are broken. You should instead have a
check that actually tries to build a small piece of code that tests if
the API is old/new and see if the builds succeeds/fails.

But yeah, waf. Good luck.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list