[Buildroot] [PATCH 5/5] package/nginx: fix error is nginx.service

[Martin Bark]

Thomas,

On 1 May 2016 at 22:47, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Sun,  1 May 2016 20:52:25 +0100, Martin Bark wrote:
>
>> -ExecStartPre=/usr/bin/mkdir -p /var/log/nginx /var/tmp/nginx; /usr/sbin/nginx -t -q -g 'pid /var/run/nginx.pid; daemon on; master_process on;'
>> +ExecStartPre=/usr/bin/mkdir -p /var/log/nginx /var/tmp/nginx ; /usr/sbin/nginx -t -q -g 'pid /var/run/nginx.pid; daemon on; master_process on;'
>
> Isn't:
>
> ExecStartPre=/usr/bin/mkdir -p /var/log/nginx /var/tmp/nginx
> ExecStartPre=/usr/sbin/nginx -t -q -g 'pid /var/run/nginx.pid; daemon on; master_process on;'
>
> a better solution?

Yes you are right, that will work and i agree it looks neater.  I'll
update the patch and resubmit.

Thanks

Martin

>
> According to man systemd.service:
>
>        ExecStartPre=, ExecStartPost=
>            Additional commands that are executed before or after the command
>            in ExecStart=, respectively. Syntax is the same as for ExecStart=,
>            except that multiple command lines are allowed and the commands are
>            executed one after the other, serially.
>
> (To be tested, I don't know much about systemd).
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com