[Buildroot] [PATCH] taskd: add patch to fix musl build issue
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat May 7 07:20:09 UTC 2016
Hello,
On Sat, 7 May 2016 01:25:03 +0200, Jörg Krause wrote:
> taskd checks for `get_current_dir_name` but forgets to add a `cmakedefine`
> in cmake.h.in, so `HAVE_GET_CURRENT_DIR_NAME` is always undefined.
>
> CMake detects correctly that the musl C library defines `get_current_dir_name`.
> However, as `HAVE_GET_CURRENT_DIR_NAME` is not set, the block of code evaluated
> cannot be compiled as musl does not define `PATH_MAX`.
>
> Reported upstream:
> https://bug.tasktools.org/browse/TD-120
>
> Fixes:
> http://autobuild.buildroot.net/results/121/121aa15235e06c80d65428626da5a2da9d11c9ba/
>
> Signed-off-by: Jörg Krause <joerg.krause at embedded.rocks>
Thanks, applied!
I saw that you asked why I rejected some of Bernd's patches fixing musl
issues, and Arnout answered you.
This patch from you is exactly what I expect: a real analysis of the
problem, a proper Git formatted patch that has a good explanation other
than "fixes musl build" and an issue reported upstream. Simply perfect.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list