[Buildroot] [PATCH] supertuxkart: new package

[Arnout Vandecappelle]

On 05/10/16 15:59, Ezequiel Garcia wrote:
> On 9 May 2016 at 20:16, Arnout Vandecappelle <arnout at mind.be> wrote:
> [..]
>>> Why? If the package bundles a glew, why not using it?
>>
>>
>
> As a matter of fact, they bunde jpeglib, libpng, zlib and a few more as well.

  jpeglib, libpng and zlib are AFAICS only used on Windows and Mac. For us, it's 
using the installed ones. You even added those dependencies :-)

>
>>  We avoid bundled libraries for several reasons:
>>
>
> Sure, I understand why bundling is a shitty idea. My point is:
> it was not OUR idea, but something that comes from upstream.
>
> I haven't checked, but given they bundle their own Irrlicht engine
> (and even they modified it enough to call it Antarctica now), it seems
> they know what they are doing.
>
> Or another possible explanation is that they are lazy, and wanted
> to bundle to make installation easier (in some non-Linux OS?).
>
> Whatever the reasons, I don't want to spend time modifying a package
> in a way that won't be accepted upstream.
>
> [..]
>>
>>  However, it's possible that supertuxkart has made project-specific
>> modifications to libglew, in this case unbundling is difficult. I see that
>> at least it is an older version than what we have.
>>
>
> Exactly my point. And even if they haven't made modifications to some of
> the bundled packages, I really don't want to spend time doing a change that
> is not in the upstream roadmap.

  Fair enough, the bundling is probably not bad enough to block this package.

  Perhaps then add a comment in the .mk file, near the dependencies list, that 
it has bundled modified versions of libglew and irrlicht. Actually we don't have 
irrlicht (yet) so for that it doesn't matter much :-)

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF